clean @ts-expect-error #12664
Merged
clean @ts-expect-error #12664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
reviewed
Apr 11, 2022
packages/jest-types/src/Global.ts
Outdated
| @@ -123,5 +123,5 @@ export interface GlobalAdditions extends TestFrameworkGlobals { | |||
| export interface Global | |||
| extends GlobalAdditions, | |||
| Omit<typeof globalThis, keyof GlobalAdditions> { | |||
| [extras: string]: unknown; | |||
| [extras: string | symbol]: unknown; | |||
There was a problem hiding this comment.
Hm.. Perhaps instead of tweaking this one, it would be better to extend Global locally inside jest-runtime/src/types.ts. In somewhat similar way:
|
If I don’t ask to much (; These also could be fixed: |
mrazauskas
reviewed
Apr 11, 2022
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
@mrazauskas I tried. but don't know how to extend |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
microsoft/TypeScript#24587 is solved by microsoft/TypeScript#44512. so we could remove the @ts-expect-error now.
Test plan
Green CI