Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yarn dedupe CI check #12717

Merged
merged 5 commits into from
Apr 23, 2022
Merged

Add Yarn dedupe CI check #12717

merged 5 commits into from
Apr 23, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Apr 23, 2022

Summary

Add a CI check yarn duplicate.

Test plan

Green CI

yarn.lock Outdated
version: 12.12.70
resolution: "@types/node@npm:12.12.70"
checksum: 69c193e0bce8fa914d478f829bd923ee662b220e069a2e00ffbe109f27d0b38fbf2a9fe78c99eb4d4ccb294248ff8de68019a2c7fadb032d301c6feca25f3d22
"@types/node@npm:*, @types/node@npm:^17.0.5":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* should refer to 12 still (we want that to be the version used in the repo)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a resolution entry in package.json to make @types/node always resolve to v12? is this a good idea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now * is resolved to v17, so typescript is failing to compile.

@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 23, 2022

BTW, will we drop node v12 support when node v12 reaches the end of life at the end of the month? @SimenB

@F3n67u F3n67u changed the title ci: add Yarn dedupe check Add Yarn dedupe CI check Apr 23, 2022
@SimenB
Copy link
Member

SimenB commented Apr 23, 2022

Nah, will keep it until at least this summer when 17 is eol

@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 23, 2022

Nah, will keep it until at least this summer when 17 is eol

do you mean the node 17 support? but what I ask is node 12's support

@F3n67u F3n67u marked this pull request as ready for review April 23, 2022 12:05
@SimenB
Copy link
Member

SimenB commented Apr 23, 2022

Yeah, we'll be keeping 12 at least as long as 17

@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 23, 2022

@SimenB ci is happy. please take a look again.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 4f1d199 into jestjs:main Apr 23, 2022
@F3n67u F3n67u deleted the yarn-dedupe branch April 24, 2022 00:14
F3n67u added a commit to F3n67u/jest that referenced this pull request May 2, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants