Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump isbinaryfile dependency to ^5.0.0 #12726

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Apr 24, 2022

Summary

bump isbinaryfile dependency to ^5.0.0

Test plan

Green CI

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit c1a57cb into jestjs:main Apr 24, 2022
@F3n67u F3n67u deleted the deps/isbinaryfile branch April 24, 2022 14:44
@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 24, 2022

@SimenB do we have any plan to migrate our package to pure ESM so that we can bump the major version of pure ESM packages Sindre Sorhus made?

I see we depend on a lot of Sindre Sorhus package. but because they are pure ESM now, so we cannot bump major version.

@SimenB
Copy link
Member

SimenB commented Apr 24, 2022

Not until ESM vm is stable: nodejs/node#37648

F3n67u added a commit to F3n67u/jest that referenced this pull request May 2, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants