Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test that unreffed workers are not reported #12798

Merged
merged 1 commit into from
May 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions e2e/__tests__/detectOpenHandles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

import {onNodeVersions} from '@jest/test-utils';
import runJest, {runContinuous} from '../runJest';

function getTextAfterTest(stderr: string) {
Expand Down Expand Up @@ -119,6 +120,19 @@ it('does not report child_process using unref', () => {
expect(textAfterTest).toBe('');
});

onNodeVersions('>=18.1.0', () => {
it('does not report worker using unref', () => {
// The test here is basically that it exits cleanly without reporting anything (does not need `until`)
const {stderr} = runJest('detect-open-handles', [
'worker',
'--detectOpenHandles',
]);
const textAfterTest = getTextAfterTest(stderr);

expect(textAfterTest).toBe('');
});
});

it('prints out info about open handlers from inside tests', async () => {
const run = runContinuous('detect-open-handles', [
'inside',
Expand Down
17 changes: 17 additions & 0 deletions e2e/detect-open-handles/__tests__/worker.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

const {Worker} = require('worker_threads');

test('something', () => {
const worker = new Worker(require.resolve('../interval-code'), {
stderr: true,
stdout: true,
});
worker.unref();
expect(true).toBe(true);
});