Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing spaces in string concats #13019

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: missing spaces in string concats #13019

merged 1 commit into from
Jul 13, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Jul 13, 2022

Summary

The missing spaces at the end of each line affects the readability of the output to the CLI.

As an example:

jest --help

...
      --coveragePathIgnorePatterns  An array of regexp pattern strings that are
                                    matched against all file paths before
                                    executing the test. If the file pathmatches
                                    any of the patterns, coverage information
                                    will be skipped.                     [array]
...

Note how "path" and "matches" are squashed together in the output.

This PR simply adds the missing spaces

Test plan

N/A

@facebook-github-bot
Copy link
Contributor

Hi @Fdawgs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

as soon as the CLA is signed I can merge 🙂

@Fdawgs
Copy link
Contributor Author

Fdawgs commented Jul 13, 2022

Thanks @SimenB, I did sign it shortly after opening this PR. Does the bot need retriggering?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Jul 13, 2022

Apparently! 😅

Thanks!

@SimenB SimenB merged commit 3d94b58 into jestjs:main Jul 13, 2022
@Fdawgs Fdawgs deleted the fix/whitespace branch July 13, 2022 12:56
@SimenB
Copy link
Member

SimenB commented Jul 13, 2022

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants