Coverage && transform refactor #1321
Conversation
ghost
added
the
|
this uses next step will be combining the instrumentation with |
aaronabramov
force-pushed
the
coverage
branch
2 times, most recently
from
ffe37ee to
43b2d67
Compare
| wrappedResult = wrap(content); | ||
| } | ||
|
|
||
| return new vm.Script(wrappedResult, {displayErrors: true, filename}); |
There was a problem hiding this comment.
TODO: better error handling around this call. All SyntaxError in the transformed source code will throw here
| .*/packages/jest-react-native/node_modules/react-native/.* | ||
| .*/node_modules/fbjs/.* |
There was a problem hiding this comment.
can you do the same for react-native, since you are at it?
| `\nScript: ${content}\n` + | ||
| `Path: ${filename}\n` + | ||
| `Config: ${stableStringify(config, {space: 2})}` | ||
| ); |
There was a problem hiding this comment.
can we keep this? I actually wanted to have the config and the original script in the snapshot.
|
This is great work. I left a bunch of minor comments but overall I love the direction this is taking and appreciate all the cleanups you are making, especially in I think one thing that's missing here is that test files themselves don't get ignored from coverage instrumentation any more. Also, please remove Can you add a test for the transform test that spits out instrumented code into a snapshot? Feel free to merge after fixing the minor nits. Great work! |
|
updated |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.