-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove ansi-escapes
#13471
chore: remove ansi-escapes
#13471
Conversation
import * as preRunMessage from './preRunMessage'; | ||
import * as specialChars from './specialChars'; | ||
|
||
export {ansiEscapes}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more idea. Additionally jest-watcher
could also expose ansiEscapes
so that plugins could use this implementation as well.
This is the primary reason for suggesting this PR, right? The issue only concerns the Jest repository, not anyone who is using Jest, is that correct? |
Instead of bloating |
@@ -19916,6 +19914,13 @@ __metadata: | |||
languageName: node | |||
linkType: hard | |||
|
|||
"type-fest@npm:^0.21.3": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't now shipped right? comes from some dev dep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. For instance lerna-lite
ships same old ansi-escapes
through inquirer
. They cannot update inquirer
, because newer version is ESM only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESM only... gotta love it 😅
@cpojer The issue with TypeScript 4.8 appeared in #13177, it was solved by adding |
Jest is too big and bloated. I don't think the project should keep taking on more responsibilities. If this is purely a Jest-internal maintenance issue on keeping around a single resolution (a package manager feature that exists exactly for the purpose we are using it for) then I would prefer not to adopt more code into this repo since the original package is working as expected. |
As long as our dependency on |
Thanks for your time (; |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Just an idea –
ansi-escapes
package can be replaced with a handful of one-liners. There is nothing wrong withansi-escapes
. Only that it ships oldtype-fest
that is causing typecheck issues with latest TS and needs specialresolutions
. Also currently Jest ships that oldtype-fest
as a transitive dependency, but it is not used at all.Test plan
Green CI.