chore: use glob to select files in buildTs script
#13850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Feb 2, 2023
| @@ -125,12 +125,13 @@ try { | |||
| await Promise.all( | |||
| packagesWithTs.map(({packageDir, pkg}) => | |||
| mutex(async () => { | |||
| const buildDir = path.resolve(packageDir, 'build/**/*.d.ts'); | |||
There was a problem hiding this comment.
Also this should not work on Windows, because the resulting pattern will have \ separators. Hence it should not select any files.
glob has the cwd option to solve this problem.
SimenB
reviewed
Feb 2, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just like other scripts in this repo, the
buildTsscript could useglobto select files. This change makes it possible to remove one dev dependency. Less efforts to maintain the repo (;Test plan
Green CI.