Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyrights with Meta Platforms, restore original license in Jasmine fork #13879

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

zpao
Copy link
Contributor

@zpao zpao commented Feb 9, 2023

Summary

In preparation for finally moving this over the OpenJS, this is just basic hygiene to reflect the copyrights as accurately as possible.

Test plan

node scripts/checkCopyrightHeaders.mjs (as well as a more aggressive git grep for files currently ignored by that script)

These were incorrectly changed from Pivotal Labs -> Facebook in jestjs#7589.
Copy link
Contributor

@mrazauskas mrazauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to draw your attention – text is not the same in all the headers. I marked just two cases which look odd, but there are more.

@@ -1,5 +1,5 @@
/**
* Copyright (c) 2016-present, Facebook, Inc. All rights reserved.
* Copyright (c) Meta Platforms, Inc. and affiliates., Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) Meta Platforms, Inc. and affiliates., Inc. All rights reserved.
* Copyright (c) Meta Platforms, Inc. and affiliates.

.eslintrc.cjs Outdated
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2016-present, Facebook, Inc. All rights reserved.
* Copyright (c) Meta Platforms, Inc. and affiliates., Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) Meta Platforms, Inc. and affiliates., Inc. All rights reserved.
* Copyright (c) Meta Platforms, Inc. and affiliates.

@SimenB
Copy link
Member

SimenB commented Feb 9, 2023

Based on https://github.com/facebook/react/pull/25315/files, the , Inc. All rights reserved. part is wrong. So I did a search and replace

@SimenB SimenB merged commit 6d2632a into jestjs:main Feb 9, 2023
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants