-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add retryImmediately option to jest.retryTimes (#14696) #14977
feat: add retryImmediately option to jest.retryTimes (#14696) #14977
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
logErrorsBeforeRetry?: boolean; | ||
waitBeforeRetry?: number; | ||
immediately?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to keep alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Could you add a type test, please? They live here: jest/packages/jest-types/__typetests__/jest.test.ts Lines 662 to 671 in d4d1f2b
To run the type tests, first build the library:
|
docs/JestObjectAPI.md
Outdated
@@ -1139,6 +1139,16 @@ test('will fail', () => { | |||
}); | |||
``` | |||
|
|||
`immediately` option is used to retry the failed test immediately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to clarify. Feel free to rework.
`immediately` option is used to retry the failed test immediately. | |
`immediately` option is used to retry the failed test immediately after the failure. If this option is not specified, the tests are retried after Jest is finished running all test in a file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice point, now it's more clear, I'll update PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff, thanks!
and thanks for reviewing @mrazauskas 🙇
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #14696 Added a new property
immediately
tojest.retryTimes
Test plan
I haven't found a smarter way than using console.log to check the order of test runs.