new jest globals

[aaronabramov]

added some globals that i always wanted.

xtest
test.only
test.skip

context
xcontext
context.only
context.skip

describe.only
describe.skip

we also need to add them to all the lint rules

[cpojer]

that is a ton of new globals.

[aaronabramov]

worth it!

still, i think the ideal solution would be to enable

{
  globals: false
}

in the config and then

import {it, describe} from 'jest';

[cpojer]

but we can't actually shadow jest with our own module because how are you gonna require jest in a jest test then?

[aaronabramov]

https://github.com/facebook/jest/blob/master/packages/jest/src/jest.js

i think we can actually export it here instead of proxying jest-cli and leave cli to jest-cli :)

do we have anything that uses require('jest') programmatically?

[cpojer]

I mean, we can probably survive.

tbh I kind of want to keep the globals. I'm not happy with the one-line boilerplate in every test…

[codecov-io]

Current coverage is 89.93% (diff: 100%)

Merging #1632 into master will not change coverage

@@             master      #1632   diff @@
==========================================
  Files            31         31          
  Lines          1143       1143          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1028       1028          
  Misses          115        115          
  Partials          0          0          

Powered by Codecov. Last update 96844eb...551ac8e

[kentcdodds]

Reeeally hoping this'll land :)

[kentcdodds]

THIS IS SOOOOO COOOOL!

[mxstbr]

This is actually an awesome use of snapshot testing!

[cpojer]

I feel like context is a very common variable name as opposed to describe and it. I don't really think we should add it now.

[kentcdodds]

Personally, I never use context, so I don't really care one way or the other, but I don't see why the existence of context on global would inhibit anyone who wanted to use a variable called context.

[aaronabramov]

yeah. let's kill context. its semantics is hard to understand too

[fson]

A pull request should probably be opened to add xtest in the Jest globals in https://github.com/sindresorhus/globals?

[cpojer]

@DmitriiAbramov is way ahead of you: sindresorhus/globals#97

[maximderbin]

@DmitriiAbramov ruby will never go out from your blood hahah

[vjeux]

@DmitriiAbramov are you going to add them to the documentation? Otherwise it's a pretty undiscoverable feature.

http://facebook.github.io/jest/docs/api.html#the-jest-global-environment

[aaronabramov]

@vjeux yes! i'll submit a PR with the docs a bit later :)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.