use process exit listener instead of process.exit() #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures that console.log is fully flushed on Windows before exiting completely
|
Thanks! |
jeffmo
added a commit
that referenced
this pull request
Jan 23, 2015
use process exit listener instead of process.exit()
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated PR using the most recent jest bin from master (from #111), and proposed solution to #110. I do not have the foggiest notion on how to write a test for this, and couldn't find any bin tests anyway...
I have manually checked on Windows 8.1, using the getting started code as the test code and running:
0.2.1)npm linkthis branch and run the tests again.The problem is present in the most recent version of jest in my example test, and this change resolves it. The added
returns prevent further code execution quite nicely it seems. In all most attempts to check it (--helpand missing local install), nothing past the return ran (I would hope not!), but theprocess.on('exit')listeners still fire.Hope that helps, its nice to finally see some output on my tests :P