Add Danger by using a subfolder #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! This is a lot safer :) |
|
If I get this green, I'll merge all the commits too 👍 and I totally get it |
Generated by 🚫 dangerJS |
|
Yep, that works. Everything is green except for Danger's fail. |
|
ok, let's try this one! Thanks so much @orta. |
|
OK, I expect this build to pass ( and I fixed the |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Initial Dangerfile, adds a rule for including flow and the FB header * [Danger] Use a local path for jest-runtime instead of the downloaded NPM package * [Danger] Makes the FB copyright header check correct * just run danger * Update Danger * Use danger from a subfolder
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Initial Dangerfile, adds a rule for including flow and the FB header * [Danger] Use a local path for jest-runtime instead of the downloaded NPM package * [Danger] Makes the FB copyright header check correct * just run danger * Update Danger * Use danger from a subfolder
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brings back Danger as discussed in #2525, but hopefully scopes the dependencies into the
/danger/folder. I'm guessing right now that this is how it works, if not, I think it's probably fine to move the Dangerfile into the danger folder, but then file paths will need to be changed inside the Dangerfile.