use Plugin type for pretty-format plugins #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Mar 8, 2017
| const isNotOrdered = (maybeOrdered: any) => !maybeOrdered[IS_ORDERED]; | ||
|
|
||
| const test = (maybeMap: any) => | ||
| !!(maybeMap && isMap(maybeMap) && isNotOrdered(maybeMap)); |
There was a problem hiding this comment.
Can we inline this? isMap and isNotOrdered functions add micro, but unnecessary, overhead to the test function
const test = (maybeMap: any) =>
!!(maybeMap && maybeMap[IS_MAP] && !maybeMap[IS_ORDERED]);
thymikee
reviewed
Mar 8, 2017
| const isNotOrdered = (maybeOrdered: any) => !maybeOrdered[IS_ORDERED]; | ||
|
|
||
| const test = (maybeSet: any) => | ||
| !!(maybeSet && isSet(maybeSet) && isNotOrdered(maybeSet)); |
|
Nice! Thanks for the cleanup. |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* use Plugin type for pretty-format plugins * removing unnecesary overhead
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* use Plugin type for pretty-format plugins * removing unnecesary overhead
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unifying the use of
typesin all the pretty-format plugins.Also, in
ImmutableMapandImmutableSetmaking sure they don't have the@@__IMMUTABLE_ORDERED__@@field. That way, the order inImmutablePluginswon't matterTest plan
yarn test