Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn-error.log to .gitignore #3384

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Conversation

pedrottimark
Copy link
Contributor

Summary

Because there were some errors when I tried yarn clean-all && yarn when I forgot the computer was offline yesterday, there were some untracked files when I checked git status today:

packages/jest-runtime/yarn-error.log
yarn-error.log

After I added a line to the .gitignore file, git does not consider those files untracked.

By the way, here are two alternative concise solutions from other repositories:

Test plan

Review by human, and thank you for it.

@cpojer cpojer merged commit fb1d6db into jestjs:master Apr 27, 2017
@cpojer
Copy link
Member

cpojer commented Apr 27, 2017

Thanks, that makes sense :)

@pedrottimark pedrottimark deleted the yarn-error-log branch April 27, 2017 14:45
@codecov-io
Copy link

Codecov Report

Merging #3384 into master will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3384      +/-   ##
==========================================
+ Coverage   64.11%   64.89%   +0.77%     
==========================================
  Files         176      176              
  Lines        6530     6521       -9     
  Branches        4        4              
==========================================
+ Hits         4187     4232      +45     
+ Misses       2342     2288      -54     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/defaults.js 100% <0%> (ø) ⬆️
packages/jest-runtime/src/transform.js 89.4% <0%> (ø) ⬆️
packages/jest-jasmine2/src/jest-expect.js 0% <0%> (ø) ⬆️
packages/jest-config/src/normalize.js 89.54% <0%> (ø) ⬆️
packages/jest-config/src/constants.js 100% <0%> (ø) ⬆️
packages/jest-cli/src/runJest.js 59.03% <0%> (+59.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c279c...919f522. Read the comment docs.

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants