Add projects option, rename initial config to options. #3400
Conversation
cpojer
force-pushed
the
config-updates
branch
2 times, most recently
from
d9c1c03 to
db58b90
Compare
packages/jest-cli/src/cli/runCLI.js
Outdated
| let hasDeprecationWarnings; | ||
| let configs = []; | ||
| let config; | ||
| if (roots.length === 1) { |
There was a problem hiding this comment.
Just to remember, we should rename roots to projects here as this is what we pass here
| )), | ||
| ); | ||
| value = list; | ||
| break; |
There was a problem hiding this comment.
Could you add a test for normalizing projects?
Codecov Report
@@ Coverage Diff @@
## master #3400 +/- ##
==========================================
+ Coverage 63.99% 64.02% +0.03%
==========================================
Files 177 177
Lines 6574 6580 +6
Branches 5 5
==========================================
+ Hits 4207 4213 +6
Misses 2365 2365
Partials 2 2
Continue to review full report at Codecov.
|
* Add projects option, rename initial config to options. * Add test
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
As discussed in the team meeting today, this makes the
--projectoption work via the cli or"project"via the configuration system. It uses globs as well, so many projects can easily be specified.I will send a follow-up PR with a test for the config option but I'm quite a bit tired right now ;)
Test plan
Add
into the top level packag.json and it will actually, really, work. Amazing.