Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Localization effort #3404

Merged
merged 5 commits into from
Apr 28, 2017
Merged

Revert Localization effort #3404

merged 5 commits into from
Apr 28, 2017

Conversation

ericnakagawa
Copy link
Contributor

@ericnakagawa ericnakagawa commented Apr 28, 2017

The Localization step caused a breakage in the main website. This reverts Localization effort.

I will submit a new PR with full confirmation that crowdin sync and website build step succeeds as expected.

There were several PRs merged throughout my commits. Three files that had clashes were:

packages/jest-runtime/src/shouldInstrument.js
packages/babel-jest/src/index.js
packages/jest-cli/src/runJest.js

Please review that these three files are as expected after the revert.

@codecov-io
Copy link

codecov-io commented Apr 28, 2017

Codecov Report

Merging #3404 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3404   +/-   ##
=======================================
  Coverage   64.27%   64.27%           
=======================================
  Files         176      176           
  Lines        6538     6538           
  Branches        4        4           
=======================================
  Hits         4202     4202           
  Misses       2335     2335           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d3314...db6404c. Read the comment docs.

@aaronabramov aaronabramov merged commit 27b53ca into jestjs:master Apr 28, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Revert Localization effort

* Reran prettier

* Revert dangerfile.js

* Reverting README.md

* Moving line alphabetical order
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants