Fix "yarn test" for website by adding injection step to siteConfig.js #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
approved these changes
May 5, 2017
Generated by 🚫 dangerJS |
… available translation files Refactored how generate works to now call translatePre.js, translate.js, and convert.js Fixed folder delete race condition Add website building scripts to prettier Fix prettier warnings Fixes page next/prev routing, updates website pages in prettier Localize page's browser title Debugging fs failure Change how it writes file to disk to create folder if missing
This was referenced May 6, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
… available translation files (jestjs#3475) Refactored how generate works to now call translatePre.js, translate.js, and convert.js Fixed folder delete race condition Add website building scripts to prettier Fix prettier warnings Fixes page next/prev routing, updates website pages in prettier Localize page's browser title Debugging fs failure Change how it writes file to disk to create folder if missing
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"yarn test" was failing for website build because we were statically requiring dynamically generated js files (en.js is created from en.json, en.json is needed by CrowdIn since it can't process a js file for translateable strings, but JSON format works). These files don't exist at CI test step, and only exist at website build step after a upload/download sync. This PR adds only the available languages to the siteConfig at runtime so that "yarn test" run from /website works and the website build step also works.
Also added fixes to navigation, and added localized titles to pages.
Test plan
Tested locally by running "yarn test" from /website when no localized JSON files and docs were present, then ran after CrowdIn download step.
Need tests on CI to pass, and will require SSH-ing in to see if files output properly.