Add failFast flag to abort test suite after first failure #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a test fails, call the reporter#onRunComplete and exit the worker process Store startTime in `aggregatedResults` instead of runTime in order to calculate total runTime at any point in time after the test has begun
Extract redundancies in failure message and header creation Remove unused runTime variable in aggregatedResults
|
I like it! nit: can we call it |
|
Sure thing! I'll push the changes up soon |
| this.log(failureMessage); | ||
| } | ||
|
|
||
| if (config.bail){ |
There was a problem hiding this comment.
nit: space before {
|
This is looks great, thanks. Let's fix the nits, and it's good to go. |
|
np. changes pushed |
| @@ -62,6 +62,10 @@ function(config, testResult, aggregatedResults) { | |||
| testRunTimeString = this._formatMsg(testRunTimeString, FAIL_COLOR); | |||
| } | |||
|
|
|||
| var resultHeader = this._getResultHeader(allTestsPassed, pathStr, [ | |||
| testRunTimeString | |||
| ]); | |||
There was a problem hiding this comment.
I believe it should be:
var resultHeader = this._getResultHeader(allTestsPassed, pathStr, [
testRunTimeString
]);There was a problem hiding this comment.
ah, right.
just pushed up the fix
|
Thanks! |
DmitrySoshnikov
added a commit
that referenced
this pull request
Jun 4, 2015
Add failFast flag to abort test suite after first failure
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #127 to add a flag to abort the test suite after the first failing test file occurs.
--bailoptions or-balias.DefaultTestReporterafter calling the cleanup method
onRunCompletein order to print the test results before abortaggregatedResults. this allows us to calculate the runTime anywhereaggregatedResultsis available. I.e. to print the overall run time during any individual test, instead of after all the tests have run.I'm currently having an issue on jest 0.4.5 (from facebook/jest/master) that is forcing noHighlight to always be called. I believe its related to pull #364, but i'm unsure if this is a persistent issue or just my machine. Its happening by default and passing
--noHighlight falsedoes not remove it.Looking forward to your feedback! @amasad
examples:
Fail fast
Fail fast, verbose
Fail fast, no highlight
