Added a new category called Framework Guides #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Guides' that will appear before the 'Guides' category
|
Nice, thank you! |
|
You're welcome. |
|
Hi @jcfausto we just changed the file structure around docs. Let me work to get this in. |
cpojer
pushed a commit
that referenced
this pull request
Oct 11, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request related to issue #4638
Summary
This modification creates a new category called "Framework Guides" whose intent is to group all guides related to testing web frameworks with Jest.
As mentioned in the issue #4638, this modification minimize the feeling that React is "the framework" and everything else is branded as "other".
Test plan
Set up:
Check:
That "Framework Guides" section appears on the left menu before the "Guides" section.
That "Framework Guides" section contains only the following 3 links:
Testing React Apps
Testing React Native Apps
Testing Web Frameworks
The menu content before this change is as follows:
The menu content after this change:
