Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack trace for errors thrown by snapshot serializers #4787

Merged
merged 5 commits into from
Oct 30, 2017
Merged

Fix stack trace for errors thrown by snapshot serializers #4787

merged 5 commits into from
Oct 30, 2017

Commits on Oct 29, 2017

  1. Fix stack trace for errors thrown by snapshot serializers 

    In this commit, we are creating a new custom error called
`PrettyFormatPluginError`, this error is thrown by `prettyFormat`
function when a serializer throws an error.

In the `expect` module, we skip `Error.captureStackTrace` if the error
name is `PrettyFormatPluginError`, this way the stack trace stays
intact.

Fixes #3302
    @nicolasiensen
    nicolasiensen committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    63e1795 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @nicolasiensen
    nicolasiensen committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    d523a22 View commit details
    Browse the repository at this point in the history

  3. Make sure new tests have assertions

    @nicolasiensen
    nicolasiensen committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    7c7069c View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2017

  1. Update CHANGELOG.md

    @cpojer
    cpojer authored Oct 30, 2017
    Configuration menu
    Copy the full SHA
    ee00b4e View commit details
    Browse the repository at this point in the history

  2. Update index.js

    @cpojer
    cpojer authored Oct 30, 2017
    Configuration menu
    Copy the full SHA
    c0d78a9 View commit details
    Browse the repository at this point in the history