Run with Jest Circus when passing the JEST_CIRCUS env variable as 1 #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will: 1. Make it easy to run a test locally with Jest Circus 2. Enable us to flag individual tests as known to be failing on Jest Circus. 3. Make it easy to run Jest Circus on other code bases. 4. Once 2 is complete, we can setup a second CI run that uses Jest Circus to ensure we don't regress.
thymikee
reviewed
May 26, 2018
scripts/SkipOnJestCircus.js
Outdated
|
|
||
| /* eslint-disable jest/no-focused-tests */ | ||
|
|
||
| const SkipOnWindows = { |
thymikee
approved these changes
May 26, 2018
SimenB
approved these changes
May 26, 2018
aaronabramov
approved these changes
May 26, 2018
|
Very cool |
|
Mind creating an issue to remove this env var once circus is shipped? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #4362
You can now run our test with:
JEST_CIRCUS=1 ./jestand it will use Jest circus.This will:
Circus.
Circus to ensure we don't regress.
Test plan
@aaronabramov