print stack trace on calls to process.exit #6714
Conversation
packages/jest-runner/src/run_test.js
Outdated
| @@ -145,6 +146,28 @@ async function runTestInternal( | |||
| // For runtime errors | |||
| sourcemapSupport.install(sourcemapOptions); | |||
|
|
|||
| const realExit = environment.global.process.exit; | |||
There was a problem hiding this comment.
What if there's no process in global? We'll be calling undefined fn, or am I missing something?
There was a problem hiding this comment.
it's always there because of the installCommonGlobals call. Of course fully custom envs won't necessarily have it...
I can wrap it in an if
Codecov Report
@@ Coverage Diff @@
## master #6714 +/- ##
==========================================
- Coverage 63.68% 63.62% -0.07%
==========================================
Files 235 235
Lines 9003 9012 +9
Branches 4 4
==========================================
Hits 5734 5734
- Misses 3268 3277 +9
Partials 1 1
Continue to review full report at Codecov.
|
* upstream/master: (122 commits) fix: don't report promises as open handles (jestjs#6716) support serializing `DocumentFragment` (jestjs#6705) Allow test titles to include array index (jestjs#6414) fix `toContain` suggest to contain equal message (jestjs#6810) fix: testMatch not working with negations (jestjs#6648) Add test cases for jestjs#6744 (jestjs#6772) print stack trace on calls to process.exit (jestjs#6714) Updates SnapshotTesting.md to provide more info. on snapshot scope (jestjs#6735) Mark snapshots as obsolete when moved to an inline snapshot (jestjs#6773) [Docs] Clarified the use of literal values as property matchers in toMatchSnapshot() (jestjs#6807) Update CHANGELOG.md (jestjs#6799) fix changelog entry that is not in 23.4.2 (jestjs#6796) Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options (jestjs#6736) Update testURL default value from about:blank to localhost (jestjs#6792) fix: `matchInlineSnapshot` when prettier dependencies are mocked (jestjs#6776) Fix retryTimes and add e2e regression test (jestjs#6762) Release v23.4.2 Docs/ExpectAPI: Correct docs for `objectContaining` (jestjs#6754) chore(packages/babel-jest) readme (jestjs#6746) docs: noted --coverage aliased by --collectCoverage (jestjs#6741) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Currently jest just exits without any helpful info if
process.exitis invoked from user-code.See the following test file:
It currently looks like this:
With the changes in this PR it looks like this:
I wanted to stick it along with the fake
process.sendfrom #5904, but to format the error I needconfig, and passing that through felt like meh. Can move it there, though?Test plan
Integration test added