Update flow typing for x.each function calls #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natealcedo
force-pushed
the
update_flow_typings
branch
4 times, most recently
from
f221719
to
d1c3817
Compare
SimenB
approved these changes
Sep 2, 2018
natealcedo
force-pushed
the
update_flow_typings
branch
from
d1c3817
to
eaee187
Compare
|
These changes have been merged upstream already (flow-typed/flow-typed#2688). Now all we need is to get CI to pass 💪 Edit: I did a force push to re-run CI. |
…uments to accept either mixed or Array<mixed>
natealcedo
force-pushed
the
update_flow_typings
branch
from
eaee187
to
07f296f
Compare
Codecov Report
@@ Coverage Diff @@
## master #6934 +/- ##
=======================================
Coverage 66.97% 66.97%
=======================================
Files 250 250
Lines 10379 10379
Branches 4 4
=======================================
Hits 6951 6951
Misses 3427 3427
Partials 1 1Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates flow typings from #6931 so that they are more inline with what #6351 fixed
Edit:
Something seems to be an issue the registry. Some of the CI installs are failing due to it. https://status.npmjs.org/incidents/v22ffls5cd6h