-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize file names in packages/jest-worker and packages/pretty-format #7316
Changes from all commits
0dabe35
d48930e
34efa09
1da498a
634a7c3
7dbb66c
ce0b80f
104ff3a
e07b770
0e7a6d2
152d476
64b87ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
|
||
import type {Config, Printer, Refs} from 'types/PrettyFormat'; | ||
|
||
import escapeHTML from './escape_html'; | ||
import escapeHTML from './escapeHTML'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you rename the rest of the files in pretty-format? There's quite a bunch of left There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey, I might have missed some, could you point out what files are left? I thought that the ones in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We want to rename every file that doesn't stick to the convention.
to have names as variables: import AsymmetricMatcher from './plugins/asymmetric_matcher';
import ConvertAnsi from './plugins/convert_ansi';
import DOMCollection from './plugins/dom_collection';
import DOMElement from './plugins/dom_element';
import Immutable from './plugins/immutable';
import ReactElement from './plugins/react_element';
import ReactTestComponent from './plugins/react_test_component'; There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But the
its falling into the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a mistake in interface, they shouldn't expose There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @thymikee Great, I will redo the exports and fix those files, thanks 👍 |
||
|
||
// Return empty string if keys is empty. | ||
export const printProps = ( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
getPrettyPrint
now only exports a single fn with the same name. Since there's no other exports there, maybe it's worth to change it to default export?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the changes, not sure if that's what you meant, please take a look 👍