Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Configuration.md #7455

Merged
merged 5 commits into from
Dec 17, 2018
Merged

Update Configuration.md #7455

merged 5 commits into from
Dec 17, 2018

Conversation

codeaholicguy
Copy link
Contributor

Summary

Update document of globalSetup, this is lacked the part of how global object work in globalSetup and globalTeardown process. This caused confusion for many people includes me.

Example issues from this:
#5731
#5424

thymikee
thymikee reviewed Dec 17, 2018
View reviewed changes
docs/Configuration.md Outdated Show resolved Hide resolved
@thymikee @codeaholicguy
Update Configuration.md
87ed861 
Co-Authored-By: codeaholicguy <codeaholicguy@users.noreply.github.com>
thymikee
thymikee reviewed Dec 17, 2018
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Now it would be great to:

  • add a changelog entry
  • update versioned docs (under website/versioned_docs) as this holds true since the beginning of introducing this feature.

@SimenB SimenB merged commit 045e407 into jestjs:master Dec 17, 2018
@SimenB
Copy link
Member

SimenB commented Dec 17, 2018

image

😅

@codeaholicguy
Copy link
Contributor Author

codeaholicguy commented Dec 17, 2018 •
edited
Loading

@thymikee So now I have to do 2 more steps.

Chore & Maintenance
[docs] Update notes for globalSetup (#7455)
  • Second, update Configuration.md in website/versioned_docs/version-23.6 with this changes.

Correct me if I am wrong.

@thymikee
Copy link
Collaborator

If @SimenB merged this without changelog, then it's not necessary 😄. But versioned docs would still be nice to add :)

@SimenB
Copy link
Member

SimenB commented Dec 17, 2018 •
edited
Loading

I don't think doc fixes need a changelog entry. New guides or something like that is nice, so people know to look for them.

Second, update Configuration.md in website/versioned_docs/version-23.6 with this changes.

The other versioned docs as well would be awesome, not just the latest one

image

@codeaholicguy
Copy link
Contributor Author

Understood

@codeaholicguy codeaholicguy deleted the patch-1 branch December 17, 2018 14:40
thymikee added a commit to spion/jest that referenced this pull request Dec 18, 2018
@thymikee
Merge branch 'master' into pr/6871
0a4ae67 
* master: (24 commits)
  Add `jest.isolateModules` for scoped module initialization (jestjs#6701)
  Migrate to Babel 7 (jestjs#7016)
  docs: changed "Great Scott!" link (jestjs#7524)
  Use reduce instead of filter+map in dependency_resolver (jestjs#7522)
  Update Configuration.md (jestjs#7455)
  Support dashed args (jestjs#7497)
  Allow % based configuration of max workers (jestjs#7494)
  chore: Standardize filenames: jest-runner pkg (jestjs#7464)
  allow `bail` setting to control when to bail out of a failing test run (jestjs#7335)
  Add issue template labels (jestjs#7470)
  chore: standardize filenames in e2e/babel-plugin-jest-hoist (jestjs#7467)
  Add node worker-thread support to jest-worker (jestjs#7408)
  Add `testPathIgnorePatterns` to CLI documentation (jestjs#7440)
  pretty-format: Omit non-enumerable symbol properties (jestjs#7448)
  Add Jest Architecture overview to docs. (jestjs#7449)
  chore: run appveyor tests on node 10
  chore: fix failures e2e test for node 8 (jestjs#7446)
  chore: update docusaurus to v1.6.0 (jestjs#7445)
  Enhancement/expect-to-be-close-to-with-infinity (jestjs#7444)
  Update CHANGELOG formatting (jestjs#7429)
  ...
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@codeaholicguy @captain-yossarian
Update Configuration.md (jestjs#7455)
e4bb456
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee left review comments

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codeaholicguy @SimenB @thymikee @facebook-github-bot