convert all exports to ESM #7548
Conversation
SimenB
force-pushed
the
esm-export
branch
3 times, most recently
from
e8ba1ba to
8221a20
Compare
Codecov Report
@@ Coverage Diff @@
## master #7548 +/- ##
=========================================
- Coverage 67.98% 67.9% -0.08%
=========================================
Files 249 248 -1
Lines 9511 9478 -33
Branches 5 6 +1
=========================================
- Hits 6466 6436 -30
+ Misses 3043 3040 -3
Partials 2 2
Continue to review full report at Codecov.
|
| toMatchInlineSnapshot, | ||
| toMatchSnapshot, | ||
| toThrowErrorMatchingInlineSnapshot, | ||
| toThrowErrorMatchingSnapshot, | ||
| }); | ||
| global.expect.extend = extend; | ||
| global.expect.assertions = assertions; | ||
| global.expect.hasAssertions = hasAssertions; |
There was a problem hiding this comment.
Aren't these methods already bound to expect? There's also expect.any, expect.anything, maybe it's better to import * as expect from 'expect';?
There was a problem hiding this comment.
I changed this back to how it was.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Better tooling using the language for modules.
Not sure about the
expectchanges, thoughts?Test plan
Green CI