Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade graceful-fs to avoid mem leak #7597

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 9, 2019

Summary

To include isaacs/node-graceful-fs#137

Test plan

Green CI

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be safe huh? :D

@SimenB
Copy link
Member Author

SimenB commented Jan 10, 2019

Yup. I noticed when upgrading a personal project that it wasn't updated since the old version was in range

@SimenB SimenB merged commit e1c226c into jestjs:master Jan 10, 2019
@SimenB SimenB deleted the up-graceful-fs branch January 10, 2019 07:43
@Shahor
Copy link

Shahor commented Feb 15, 2019

Hey guys!

Has this been part of a latest release on jest?

I'm having memory leaks issues and if I run yarn why graceful-fs I still have mentions of graceful-fs@4.1.11 for jest-cli:

yarn why v1.13.0
[1/4] Why do we have the module "graceful-fs"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
info 
=> Found "graceful-fs@4.1.11"
info Has been hoisted to "graceful-fs"
info Reasons this module exists
   - Hoisted from "write-file-atomic#graceful-fs"
   - Hoisted from "configstore#graceful-fs"
   - Hoisted from "sequelize-cli#fs-extra#graceful-fs"
   - Hoisted from "nodemon#chokidar#readdirp#graceful-fs"
   - Hoisted from "html-pdf#phantomjs-prebuilt#fs-extra#graceful-fs"
   - Hoisted from "@google-cloud#storage#gcs-resumable-upload#configstore#graceful-fs"
   - Hoisted from "eslint#file-entry-cache#flat-cache#graceful-fs"
   - Hoisted from "sequelize-cli#fs-extra#jsonfile#graceful-fs"
   - Hoisted from "html-pdf#phantomjs-prebuilt#fs-extra#jsonfile#graceful-fs"
   - Hoisted from "html-pdf#phantomjs-prebuilt#fs-extra#klaw#graceful-fs"
   - Hoisted from "textract#meow#read-pkg-up#read-pkg#path-type#graceful-fs"
   - Hoisted from "textract#meow#read-pkg-up#read-pkg#load-json-file#graceful-fs"
   - Hoisted from "jest-cli#jest-runtime#babel-plugin-istanbul#test-exclude#read-pkg-up#read-pkg#load-json-file#graceful-fs"
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info 
=> Found "jest-cli#graceful-fs@4.1.15"
info This module exists because "jest-cli" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info 
=> Found "jest-runtime#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-runtime" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info 
=> Found "jest-haste-map#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-haste-map" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info 
=> Found "jest-util#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-util" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info 
=> Found "jest-runner#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-runner" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info 
=> Found "jest-runtime#write-file-atomic#graceful-fs@4.1.11"
info This module exists because "jest-cli#jest-runtime#write-file-atomic" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
Done in 1.19s.

@SimenB
Copy link
Member Author

SimenB commented Feb 15, 2019

The jest-cli one in your output comes from istanbul - you an see jest-cli (and other jest deps) pulling in 4.1.15.

You need to dedupe your tree. Either by deleting the lockfile and generating a new one or using e.g. yarn-deduplicate.

Yarn issue: yarnpkg/yarn#3778

@Shahor
Copy link

Shahor commented Feb 18, 2019

Thank you @SimenB

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants