-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade graceful-fs to avoid mem leak #7597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be safe huh? :D
Yup. I noticed when upgrading a personal project that it wasn't updated since the old version was in range |
Hey guys! Has this been part of a latest release on jest? I'm having memory leaks issues and if I run yarn why v1.13.0
[1/4] Why do we have the module "graceful-fs"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
info
=> Found "graceful-fs@4.1.11"
info Has been hoisted to "graceful-fs"
info Reasons this module exists
- Hoisted from "write-file-atomic#graceful-fs"
- Hoisted from "configstore#graceful-fs"
- Hoisted from "sequelize-cli#fs-extra#graceful-fs"
- Hoisted from "nodemon#chokidar#readdirp#graceful-fs"
- Hoisted from "html-pdf#phantomjs-prebuilt#fs-extra#graceful-fs"
- Hoisted from "@google-cloud#storage#gcs-resumable-upload#configstore#graceful-fs"
- Hoisted from "eslint#file-entry-cache#flat-cache#graceful-fs"
- Hoisted from "sequelize-cli#fs-extra#jsonfile#graceful-fs"
- Hoisted from "html-pdf#phantomjs-prebuilt#fs-extra#jsonfile#graceful-fs"
- Hoisted from "html-pdf#phantomjs-prebuilt#fs-extra#klaw#graceful-fs"
- Hoisted from "textract#meow#read-pkg-up#read-pkg#path-type#graceful-fs"
- Hoisted from "textract#meow#read-pkg-up#read-pkg#load-json-file#graceful-fs"
- Hoisted from "jest-cli#jest-runtime#babel-plugin-istanbul#test-exclude#read-pkg-up#read-pkg#load-json-file#graceful-fs"
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info
=> Found "jest-cli#graceful-fs@4.1.15"
info This module exists because "jest-cli" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info
=> Found "jest-runtime#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-runtime" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info
=> Found "jest-haste-map#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-haste-map" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info
=> Found "jest-util#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-util" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info
=> Found "jest-runner#graceful-fs@4.1.15"
info This module exists because "jest-cli#jest-runner" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
info
=> Found "jest-runtime#write-file-atomic#graceful-fs@4.1.11"
info This module exists because "jest-cli#jest-runtime#write-file-atomic" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "44KB"
info Disk size with transitive dependencies: "44KB"
info Number of shared dependencies: 0
Done in 1.19s. |
The You need to dedupe your tree. Either by deleting the lockfile and generating a new one or using e.g. Yarn issue: yarnpkg/yarn#3778 |
Thank you @SimenB |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
To include isaacs/node-graceful-fs#137
Test plan
Green CI