Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused @babel/core dep from jest-config #7716

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Jan 26, 2019

Summary

Spotted while reading this comment #7715 (comment). It adds unnecessary babel downloads to anyone that depends on jest-junit. cc @SimenB @palmerj3

Test plan

Green

@SimenB
Copy link
Member

SimenB commented Jan 26, 2019

It's there due to the dependency on babel-jest which has a peer dep on @babel/core. We need it for Yarn PnP to work.

Came from #5931.

@thymikee
Copy link
Collaborator Author

I knew I missed something, thanks

@thymikee thymikee closed this Jan 26, 2019
@SimenB
Copy link
Member

SimenB commented Jan 26, 2019

We might wanna split it out somehow, maybe move defaults and utilities into a separate package from the normalization?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants