-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update jsdom to latest 13.2.0 #7763
Conversation
jsdom finally got MutationObserver.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thanks for the PR. Unfortunately we cannot accept it, as this is a breaking change in Node compat. Please see #7122 for details |
Thx for the information! |
(in particular, take a look at https://www.npmjs.com/package/jest-environment-jsdom-thirteen if you need recent |
@thymikee question: is there any plan (or time frame) to drop nodejs v6 support in future? |
Webpack, like Jest, supports node 6: https://github.com/webpack/webpack/blob/07d4d8560060c102a1aed97844d452547d02b1d4/package.json#L86 We will drop Node 6 when it's EOL, which will happen by the end of April: https://github.com/nodejs/Release/blob/master/README.md |
Sorry, my memory was wrong. It was some webpack plugin we used.
Good to know! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
jsdom finally got MutationObserver.
Test plan
Tested with plain jest setup. MutationObserver is available as global variable.