Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update jsdom to latest 13.2.0 #7763

Closed
wants to merge 2 commits into from
Closed

chore: update jsdom to latest 13.2.0 #7763

wants to merge 2 commits into from

Conversation

3cp
Copy link

@3cp 3cp commented Jan 30, 2019

Summary

jsdom finally got MutationObserver.

Test plan

Tested with plain jest setup. MutationObserver is available as global variable.

jsdom finally got MutationObserver.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@thymikee
Copy link
Collaborator

Thanks for the PR. Unfortunately we cannot accept it, as this is a breaking change in Node compat. Please see #7122 for details

@thymikee thymikee closed this Jan 30, 2019
@3cp
Copy link
Author

3cp commented Jan 30, 2019

Thx for the information!

@jeysal
Copy link
Contributor

jeysal commented Jan 30, 2019

(in particular, take a look at https://www.npmjs.com/package/jest-environment-jsdom-thirteen if you need recent jsdom features)

@3cp
Copy link
Author

3cp commented Jan 30, 2019

@thymikee question: is there any plan (or time frame) to drop nodejs v6 support in future?
Webpack had dropped nodejs v6 support for quite a while. Webpack+jest is the most common env for jest users, which makes nodejs v6 irrelevant.

@SimenB
Copy link
Member

SimenB commented Jan 30, 2019

Webpack, like Jest, supports node 6: https://github.com/webpack/webpack/blob/07d4d8560060c102a1aed97844d452547d02b1d4/package.json#L86

We will drop Node 6 when it's EOL, which will happen by the end of April: https://github.com/nodejs/Release/blob/master/README.md

@3cp
Copy link
Author

3cp commented Jan 30, 2019

Sorry, my memory was wrong. It was some webpack plugin we used.

We will drop Node 6 when it's EOL, which will happen by the end of April:

Good to know!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants