fix: Windows-specific test timeout issues introduced by Yarn 1.13.0 #7838
Conversation
See jestjs#7760 for details * Change e2e/runJest.js to invoke node directly to avoid issue with hung process/test when invoked asynchronously ("until" method) * Refactor to avoid duplication between runJest and until methods * Undo downgrade of Yarn (to 1.9.4) in Azure Pipelines Windows jobs * Add /reports/* to .gitignore (these are junit test reports normally created in CI runs)
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thanks for doing this, option 1 from your comment sounds like the best one to me as well, especially since it does pretty much the same thing that Yarn could do to fix this behavior with |
| } | ||
|
|
||
| // Spawns Jest and returns either a Promise (if spawnAsync is true) or the completed child process | ||
| function spawnJest( |
There was a problem hiding this comment.
Pretty nice refactor to avoid the code duplication btw, regardless of the actual fix 👍
There was a problem hiding this comment.
Yeah - I was gonna circle back to this when I wrote it, but never got around to it... Nice and clean now :)
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
One option for addressing #7760
Summary
See #7760 for details
Test plan
Tested on Windows, Linux, mac