Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade babel dependencies #8011

Closed
wants to merge 15 commits into from
Closed

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 28, 2019

Summary

I tried doing this on master, but it broke node 6 in horrible ways 😅 I've been a bit more thorough this time (I guess it was some mismatch of babel packages somehow that caused the failure)

We need to upgrade for babel/babel#9302, which is in 7.3.0

Test plan

Green CI

@SimenB
Copy link
Member Author

SimenB commented Feb 28, 2019

I'm unable to reproduce the CI failure...

@SimenB
Copy link
Member Author

SimenB commented Feb 28, 2019

I was able to reproduce after letting the tests run for a long time. Which tests fail seems to be random. And a second right after, no changes, passed

One of the test runs on CI ended in a segfault, fwiw.

@danez
Copy link
Contributor

danez commented Mar 2, 2019

What steps are necessary in order to get jest to build locally? I did run yarn but i fails with this:

$ yarn build:ts
$ node scripts/buildTs.js
Building TypeScript definition files
Building...................................................................................................................................................error TS5055: Cannot write file '/Github/jest/packages/jest-diff/build/index.d.ts' because it would overwrite input file.

error TS5055: Cannot write file '/Github/jest/packages/jest-diff/build/types.d.ts' because it would overwrite input file.

packages/jest-runtime/src/index.ts:22:22 - error TS2307: Cannot find module 'jest-snapshot'.

22 import Snapshot from 'jest-snapshot';
                        ~~~~~~~~~~~~~~~

packages/jest-resolve-dependencies/src/index.ts:11:48 - error TS2307: Cannot find module 'jest-snapshot'.

11 import {isSnapshotPath, SnapshotResolver} from 'jest-snapshot';
                                                  ~~~~~~~~~~~~~~~


Found 4 errors.


Unable to build TypeScript definition files
Error: Command failed: tsc -b /Github/jest/packages/babel-jest /Github/jest/packages/babel-plugin-jest-hoist /Github/jest/packages/diff-sequences /Github/jest/packages/expect /Github/jest/packages/jest-changed-files /Github/jest/packages/jest-circus /Github/jest/packages/jest-config /Github/jest/packages/jest-diff /Github/jest/packages/jest-docblock /Github/jest/packages/jest-each /Github/jest/packages/jest-environment /Github/jest/packages/jest-environment-jsdom /Github/jest/packages/jest-environment-node /Github/jest/packages/jest-fake-timers /Github/jest/packages/jest-get-type /Github/jest/packages/jest-haste-map /Github/jest/packages/jest-leak-detector /Github/jest/packages/jest-matcher-utils /Github/jest/packages/jest-message-util /Github/jest/packages/jest-mock /Github/jest/packages/jest-phabricator /Github/jest/packages/jest-regex-util /Github/jest/packages/jest-repl /Github/jest/packages/jest-resolve /Github/jest/packages/jest-resolve-dependencies /Github/jest/packages/jest-runner /Github/jest/packages/jest-runtime /Github/jest/packages/jest-serializer /Github/jest/packages/jest-snapshot /Github/jest/packages/jest-transform /Github/jest/packages/jest-types /Github/jest/packages/jest-util /Github/jest/packages/jest-validate /Github/jest/packages/jest-watcher /Github/jest/packages/jest-worker /Github/jest/packages/pretty-format /Github/jest/packages/test-utils
    at makeError (/Github/jest/node_modules/execa/index.js:174:9)
    at Function.module.exports.sync (/Github/jest/node_modules/execa/index.js:338:15)
    at Object.<anonymous> (/Github/jest/scripts/buildTs.js:29:9)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:283:19)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@SimenB
Copy link
Member Author

SimenB commented Mar 2, 2019

gah, gotta fix that. You can do yarn build-clean && yarn and it should successfully build

@SimenB
Copy link
Member Author

SimenB commented Aug 22, 2019

Upgraded in #8850

@SimenB SimenB closed this Aug 22, 2019
@SimenB SimenB deleted the upgrade-babel branch August 22, 2019 21:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants