-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps Yarn to 1.15 #8095
Bumps Yarn to 1.15 #8095
Conversation
d3421eb
to
4af97e0
Compare
Node 6 seems to have failed due to an OOM - does that happen regularly? |
Never seen it happen so far, although we do know that |
Although the |
Wow that's a lot! Ok, good to merge then? |
Should do a rerun to be safe. I don't have permission to trigger builds (maybe you do as an org member), otherwise |
Failed again, this time due to timeout. This hasn't happened on any of the recent master builds. There's something fishy going on here that deteriorates the performance of postinstall |
Nope 🤔 and I don't see memory differences when trying locally with |
I may have an idea - my theory is that TypeScript tries to somehow parse the Yarn release file. Since it's relatively large, it crashes on Node 6. I've tried adding those files to the exclude list, let's see what happens. |
Thought about that as well, but |
Seems to have worked! I'll remove the useless releases still checked-in, and if both run are green I'd be relatively confident the problem is fixed. Very interesting to know! |
Oh, that's interesting! It makes sense to ignore it anyways, but it shouldn't die anyways... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes
The TS step went through, so looking good 🙂 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This diff uses the
yarn-path
configuration settings to ensure that Jest always run with the specified Yarn release, regardless of the one used in the global environment.I've also removed
workspaces-experimental
since it's not required anymore.Test plan
Ran
yarn -v
in the repo, got1.15
. CI should print it as well.