jest-snapshot: Improve report when matcher fails, part 14

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ### Features
 
+- `[jest-snapshot]` Improve report when matcher fails, part 14 ([#8132](https://github.com/facebook/jest/pull/8132))
+
 ### Fixes
 
 ### Chore & Maintenance

e2e/__tests__/__snapshots__/failures.test.ts.snap

@@ -387,9 +387,9 @@ FAIL __tests__/snapshotNamed.test.js
 
   ● failing named snapshot
 
-    expect(value).toMatchSnapshot()
+    expect(received).toMatchSnapshot(name)
 
-    Received value does not match stored snapshot "failing named snapshot: snapname 1".
+    Snapshot key: \`failing named snapshot: snapname 1\`
 
     - Snapshot
     + Received
@@ -819,9 +819,9 @@ FAIL __tests__/snapshot.test.js
 
   ● failing snapshot
 
-    expect(value).toMatchSnapshot()
+    expect(received).toMatchSnapshot()
 
-    Received value does not match stored snapshot "failing snapshot 1".
+    Snapshot key: \`failing snapshot 1\`
 
     - Snapshot
     + Received

e2e/__tests__/__snapshots__/watchModeUpdateSnapshot.test.ts.snap

@@ -4,8 +4,8 @@ exports[`can press "u" to update snapshots: test results 1`] = `
 FAIL __tests__/bar.spec.js
   ✕ bar
   ● bar
-    expect(value).toMatchSnapshot()
-    Received value does not match stored snapshot "bar 1".
+    expect(received).toMatchSnapshot()
+    Snapshot key: \`bar 1\`
     - Snapshot
     + Received
     - "foo"

e2e/__tests__/toMatchInlineSnapshot.test.ts

@@ -52,7 +52,7 @@ test('basic support', () => {
     });
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
     const fileAfter = readFile(filename);
-    expect(stderr).toMatch('Received value does not match stored snapshot');
+    expect(stderr).toMatch('Snapshot key: `inline snapshots 1`');
     expect(status).toBe(1);
     expect(wrap(fileAfter)).toMatchSnapshot('snapshot mismatch');
   }
@@ -101,9 +101,7 @@ test('handles property matchers', () => {
     });
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
     const fileAfter = readFile(filename);
-    expect(stderr).toMatch(
-      'Received value does not match snapshot properties for "handles property matchers 1".',
-    );
+    expect(stderr).toMatch('Snapshot key: `handles property matchers 1`');
     expect(stderr).toMatch('Snapshots:   1 failed, 1 total');
     expect(status).toBe(1);
     expect(wrap(fileAfter)).toMatchSnapshot('snapshot failed');

e2e/__tests__/toMatchSnapshot.test.ts

@@ -42,7 +42,7 @@ test('basic support', () => {
       [filename]: template(['{apple: "updated value"}']),
     });
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
-    expect(stderr).toMatch('Received value does not match stored snapshot');
+    expect(stderr).toMatch('Snapshot key: `snapshots 1`');
     expect(status).toBe(1);
   }
 
@@ -107,7 +107,7 @@ test('first snapshot fails, second passes', () => {
   {
     writeFiles(TESTS_DIR, {[filename]: template([`'kiwi'`, `'banana'`])});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
-    expect(stderr).toMatch('Received value does not match stored snapshot');
+    expect(stderr).toMatch('Snapshot key: `snapshots 1`');
     expect(stderr).toMatch('- "apple"\n    + "kiwi"');
     expect(stderr).not.toMatch('1 obsolete snapshot found');
     expect(status).toBe(1);
@@ -178,9 +178,7 @@ test('handles property matchers', () => {
   {
     writeFiles(TESTS_DIR, {[filename]: template(['"string"'])});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
-    expect(stderr).toMatch(
-      'Received value does not match snapshot properties for "handles property matchers 1".',
-    );
+    expect(stderr).toMatch('Snapshot key: `handles property matchers 1`');
     expect(stderr).toMatch('Snapshots:   1 failed, 1 total');
     expect(status).toBe(1);
   }
@@ -253,9 +251,9 @@ test('handles property matchers with custom name', () => {
     writeFiles(TESTS_DIR, {[filename]: template(['"string"'])});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
     expect(stderr).toMatch(
-      'Received value does not match snapshot properties for "handles property matchers with name: custom-name 1".',
+      'Snapshot key: `handles property matchers with name: custom-name 1`',
     );
-    expect(stderr).toMatch('Expected snapshot to match properties:');
+    expect(stderr).toMatch('Expected properties:');
     expect(stderr).toMatch('Snapshots:   1 failed, 1 total');
     expect(status).toBe(1);
   }
@@ -285,9 +283,9 @@ test('handles property matchers with deep properties', () => {
     writeFiles(TESTS_DIR, {[filename]: template(['"string"', '"Jest"'])});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
     expect(stderr).toMatch(
-      'Received value does not match snapshot properties for "handles property matchers with deep properties 1".',
+      'Snapshot key: `handles property matchers with deep properties 1`',
     );
-    expect(stderr).toMatch('Expected snapshot to match properties:');
+    expect(stderr).toMatch('Expected properties:');
     expect(stderr).toMatch('Snapshots:   1 failed, 1 total');
     expect(status).toBe(1);
   }
@@ -296,7 +294,7 @@ test('handles property matchers with deep properties', () => {
     writeFiles(TESTS_DIR, {[filename]: template(['new Date()', '"CHANGED"'])});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
     expect(stderr).toMatch(
-      'Received value does not match stored snapshot "handles property matchers with deep properties 1"',
+      'Snapshot key: `handles property matchers with deep properties 1`',
     );
     expect(stderr).toMatch('Snapshots:   1 failed, 1 total');
     expect(status).toBe(1);

e2e/__tests__/toThrowErrorMatchingInlineSnapshot.test.ts

@@ -81,9 +81,7 @@ test('cannot be used with .not', () => {
   {
     writeFiles(TESTS_DIR, {[filename]: template()});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
-    expect(stderr).toMatch(
-      'Jest: `.not` cannot be used with `.toThrowErrorMatchingInlineSnapshot()`.',
-    );
+    expect(stderr).toMatch('.not cannot be used with snapshot matchers');
     expect(status).toBe(1);
   }
 });

e2e/__tests__/toThrowErrorMatchingSnapshot.test.ts

@@ -43,7 +43,7 @@ test(`throws the error if tested function didn't throw error`, () => {
   {
     writeFiles(TESTS_DIR, {[filename]: template()});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
-    expect(stderr).toMatch(`Expected the function to throw an error.`);
+    expect(stderr).toMatch('Received function did not throw');
     expect(status).toBe(1);
   }
 });
@@ -74,9 +74,7 @@ test('cannot be used with .not', () => {
   {
     writeFiles(TESTS_DIR, {[filename]: template()});
     const {stderr, status} = runJest(DIR, ['-w=1', '--ci=false', filename]);
-    expect(stderr).toMatch(
-      'Jest: `.not` cannot be used with `.toThrowErrorMatchingSnapshot()`.',
-    );
+    expect(stderr).toMatch('.not cannot be used with snapshot matchers');
     expect(status).toBe(1);
   }
 });

e2e/snapshot/__tests__/snapshot.test.js

@@ -31,7 +31,7 @@ describe('snapshot', () => {
 
   it('cannot be used with .not', () => {
     expect(() => expect('').not.toMatchSnapshot()).toThrow(
-      'Jest: `.not` cannot be used with `.toMatchSnapshot()`.'
+      '.not cannot be used with snapshot matchers'
     );
   });