Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete obsolete emails tag from header comment in test files #8377

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

pedrottimark
Copy link
Contributor

Summary

Delete 14 occurrences of * @emails oncall+jsinfra line in header comment:

  • e2e/babel-plugin-jest-hoist/__tests__/integration.test.js
  • e2e/babel-plugin-jest-hoist/__tests__/integrationAutomockOff.test.js
  • e2e/babel-plugin-jest-hoist/__tests__/typescript.test.ts
  • e2e/failures/__tests__/assertionCount.test.js
  • e2e/failures/__tests__/assertionError.test.js
  • e2e/failures/__tests__/asyncFailures.test.js
  • e2e/failures/__tests__/errorAfterTestComplete.test.js
  • e2e/failures/__tests__/snapshot.test.js
  • e2e/failures/__tests__/snapshotWithHint.test.js
  • e2e/failures/__tests__/testMacro.test.js
  • e2e/snapshot-mock-fs/__tests__/snapshot.test.js
  • e2e/snapshot/__tests__/secondSnapshot.test.js
  • e2e/snapshot/__tests__/snapshot.test.js
  • packages/jest-runtime/src/__tests__/Runtime-sourceMaps.test.js

Test plan

Now I remember why I didn’t delete them when I first noticed:

  • 5 snapshots in e2e/__tests__/__snapshots__/failures.test.ts.snap
  • 3 toContain expected strings in e2e/__tests__/failures.test.ts

CI will tell us how effective my local testing of Node versions was (made me feel like Simen lite :)

@@ -4,7 +4,6 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blank line under license can probably go too, yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few .ts files that I looked at for example have one:

 * LICENSE file in the root directory of this source tree.
 *
 */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's totally inconsistent across the code base. I've learned to ignore it ^^

Copy link
Member

@SimenB SimenB Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lazy removal of @flow pragmas is my guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is a tactful way to say that I was consistently lazy, bro ❤️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #8377 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8377   +/-   ##
=======================================
  Coverage   62.29%   62.29%           
=======================================
  Files         266      266           
  Lines       10729    10729           
  Branches     2609     2609           
=======================================
  Hits         6684     6684           
  Misses       3460     3460           
  Partials      585      585

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3c1a1...2b9cf15. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants