Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: multipleValidOptions types #8435

Merged
merged 2 commits into from
May 7, 2019

Conversation

JoshRosenstein
Copy link
Contributor

@JoshRosenstein JoshRosenstein commented May 7, 2019

Summary

Partof: #8436
Fix typing's for (jest-validate)-multipleValidOptions , which removes a few @ts-ignore TODO in (jest-config)-ValidConfig

Test plan

TS builds doesnt fail

@codecov-io
Copy link

Codecov Report

Merging #8435 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8435   +/-   ##
=======================================
  Coverage   62.33%   62.33%           
=======================================
  Files         266      266           
  Lines       10737    10737           
  Branches     2615     2615           
=======================================
  Hits         6693     6693           
  Misses       3461     3461           
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-config/src/ValidConfig.ts 100% <ø> (ø) ⬆️
packages/jest-validate/src/condition.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2297194...d2f625c. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks!

@SimenB SimenB merged commit b3f54e7 into jestjs:master May 7, 2019
@JoshRosenstein JoshRosenstein deleted the types-multipleValidOptions branch May 15, 2019 13:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants