jest-snapshot: Omit irrelevant received properties when property matchers fail #9198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9198 +/- ##
=======================================
Coverage 64.83% 64.83%
=======================================
Files 279 279
Lines 11742 11742
Branches 2887 2886 -1
=======================================
Hits 7613 7613
Misses 3511 3511
Partials 618 618
Continue to review full report at Codecov.
|
SimenB
reviewed
Nov 17, 2019
| @@ -6,6 +6,7 @@ | |||
| */ | |||
|
|
|||
| import chalk = require('chalk'); | |||
| import {getObjectSubset} from 'expect/build/utils'; | |||
SimenB
reviewed
Nov 17, 2019
pedrottimark
changed the title
SimenB
reviewed
Nov 17, 2019
ayush000
added a commit
to ayush000/jest
that referenced
this pull request
Nov 21, 2019
* master: chore: upgrade to fsevents 2 (jestjs#9215) docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149) chore: bump to istanbul alphas (jestjs#9192) Fix typo in JestPlatform.md (jestjs#9212) jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203) fix(jest-types): tighten Config types and set more defaults (jestjs#9200) jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132) jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198) chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197) fix(pretty-format): correctly detect memo (jestjs#9196) chore: regenerate lockfiles in e2e tests (jestjs#9193) chore: bump handlebars
This was referenced Jan 28, 2020
This was referenced Feb 4, 2020
This was referenced Feb 18, 2020
This was referenced Mar 3, 2020
This was referenced Mar 10, 2020
This was referenced Mar 24, 2020
This was referenced Apr 16, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Call
getObjectSubsetto be consistent withtoMatchObjectExpected propertiesversusReceived valuecan also hide the problem in a mess of irrelevant detailsBecause the long-term solution is data-driven diff, please forgive a temporary hack to import
getObjectSubsetwhich is a private helper function of theexpectpackageSimen, when I wrote
'expect/src/utils'the package tests ran okay, but the example test outside Jest threw an error, so is this correct instead:Test plan
In
printSnapshot.test.tsExample picture baseline at left and improved at right