-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash on unix based systems without find #9579
fix: crash on unix based systems without find #9579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
+ Coverage 65.07% 65.08% +<.01%
==========================================
Files 286 286
Lines 12144 12146 +2
Branches 3010 3011 +1
==========================================
+ Hits 7903 7905 +2
Misses 3605 3605
Partials 636 636
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think the helper needs some tweaks but overall this looks nice 👍
This comment has been minimized.
This comment has been minimized.
Seems like the build is broken on Node v13.x on ubuntu-latest, but I couldn't understand why 🤔 |
This reverts commit a8f28fe.
Codecov Report
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
+ Coverage 65.07% 65.11% +0.03%
==========================================
Files 286 286
Lines 12144 12151 +7
Branches 3010 3011 +1
==========================================
+ Hits 7903 7912 +9
+ Misses 3605 3604 -1
+ Partials 636 635 -1
Continue to review full report at Codecov.
|
Sorry to bug you, but just curious how the Jest releases work and when this fix would become available to the public? Thank you for the fix! |
We can make a minor release by the end of the month! |
@DiZy would the minor release be in jest@21.3.0-beta.15? I am having this issue on Node12 on AWS, which is not even using Windows. It is using the Ubuntu Standard 3.0 Docker image. |
@DiZy status of this? |
+1 also waiting on a release here. Is there anywhere documented your clear release schedule? |
I cannot even pull in the latest commits from the master branch:
|
25.2.0 has been published with this fix @lovefamilychildrenhappiness we don't support installing from github. I'll be looking into setting up canary publishes on every commit in the near future so people are not blocked by releases if they want the latest and greatest |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Closes #9329
Test plan
Unit tests added