-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move execution of setupFiles
to jest-runner
#9596
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,36 +5,20 @@ | |
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
import clearLine from './clearLine'; | ||
import createDirectory from './createDirectory'; | ||
import ErrorWithStack from './ErrorWithStack'; | ||
import installCommonGlobals from './installCommonGlobals'; | ||
import interopRequireDefault from './interopRequireDefault'; | ||
import isInteractive from './isInteractive'; | ||
import isPromise from './isPromise'; | ||
import setGlobal from './setGlobal'; | ||
import deepCyclicCopy from './deepCyclicCopy'; | ||
import convertDescriptorToString from './convertDescriptorToString'; | ||
export {default as clearLine} from './clearLine'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. snuck this in |
||
export {default as createDirectory} from './createDirectory'; | ||
export {default as ErrorWithStack} from './ErrorWithStack'; | ||
export {default as installCommonGlobals} from './installCommonGlobals'; | ||
export {default as interopRequireDefault} from './interopRequireDefault'; | ||
export {default as isInteractive} from './isInteractive'; | ||
export {default as isPromise} from './isPromise'; | ||
export {default as setGlobal} from './setGlobal'; | ||
export {default as deepCyclicCopy} from './deepCyclicCopy'; | ||
export {default as convertDescriptorToString} from './convertDescriptorToString'; | ||
import * as specialChars from './specialChars'; | ||
import replacePathSepForGlob from './replacePathSepForGlob'; | ||
import testPathPatternToRegExp from './testPathPatternToRegExp'; | ||
export {default as replacePathSepForGlob} from './replacePathSepForGlob'; | ||
export {default as testPathPatternToRegExp} from './testPathPatternToRegExp'; | ||
import * as preRunMessage from './preRunMessage'; | ||
import pluralize from './pluralize'; | ||
export {default as pluralize} from './pluralize'; | ||
|
||
export { | ||
ErrorWithStack, | ||
clearLine, | ||
convertDescriptorToString, | ||
createDirectory, | ||
deepCyclicCopy, | ||
installCommonGlobals, | ||
interopRequireDefault, | ||
isInteractive, | ||
isPromise, | ||
pluralize, | ||
preRunMessage, | ||
replacePathSepForGlob, | ||
setGlobal, | ||
specialChars, | ||
testPathPatternToRegExp, | ||
}; | ||
export {preRunMessage, specialChars}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do this up here since it happened in the constructor previously. However, I wonder if it makes more sense to do it after we call the environment's
setup
function further down? If not, maybe right before? Seems like they belong togetherhttps://github.com/facebook/jest/blob/9fbe3c5bd07002d569a1b4037d53556244a728cd/packages/jest-runner/src/runTest.ts#L230
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can mark it as a todo for later, to group similar features together. However for now, to avoid unintended breakages, I'd stay with what's closer to previous version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, makes sense