Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update example to react-native@0.62 #9746

Merged
merged 6 commits into from
Apr 23, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions examples/react-native/__tests__/__snapshots__/intro.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ exports[`renders the FlatList component 1`] = `
initialNumToRender={10}
keyExtractor={[Function]}
maxToRenderPerBatch={10}
numColumns={1}
onContentSizeChange={[Function]}
onEndReachedThreshold={2}
onLayout={[Function]}
Expand Down Expand Up @@ -106,17 +105,6 @@ exports[`renders the FlatList component 1`] = `
</RCTScrollView>
`;

exports[`renders the Image component 1`] = `
<Image
style={
Object {
"height": 240,
"width": 320,
}
}
/>
`;

exports[`renders the TextInput component 1`] = `
<TextInput
allowFontScaling={true}
Expand Down
8 changes: 0 additions & 8 deletions examples/react-native/__tests__/intro.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@ it('renders the ActivityIndicator component', () => {
expect(tree).toMatchSnapshot();
});

it('renders the Image component', done => {
Image.getSize('path.jpg', (width, height) => {
const tree = renderer.create(<Image style={{height, width}} />).toJSON();
expect(tree).toMatchSnapshot();
done();
});
});

it('renders the TextInput component', () => {
const tree = renderer
.create(<TextInput autoCorrect={false} value="apple banana kiwi" />)
Expand Down
8 changes: 4 additions & 4 deletions examples/react-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
"test": "jest"
},
"dependencies": {
"react": "16.9.0",
"react-native": "0.61.5"
"react": "16.11.0",
"react-native": "0.62.0"
},
"devDependencies": {
"@babel/core": "*",
"@babel/preset-env": "*",
"babel-jest": "*",
"jest": "*",
"metro-react-native-babel-preset": "*",
"react-test-renderer": "16.9.0"
"metro-react-native-babel-preset": "^0.58.0",
Copy link
Member Author

@SimenB SimenB Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had to manually roll back this in the lock file a few times, and it should be at a specific version anyways, so let's specify it

"react-test-renderer": "16.11.0"
}
}
Loading