fix: drop getters and setters when diffing objects for error

CHANGELOG.md

@@ -3,6 +3,8 @@
 ### Features
 
 ### Fixes
+
+- `[jest-matcher-utils]` Do not override properties with setters when diffing objects ([#9757](https://github.com/facebook/jest/pull/9757))
 - `[@jest/watcher]` Correct return type of `shouldRunTestSuite` for `JestHookEmitter` ([#9753](https://github.com/facebook/jest/pull/9753))
 
 ### Chore & Maintenance

packages/expect/src/__tests__/__snapshots__/matchers.test.js.snap

@@ -2082,6 +2082,18 @@ Expected: <g>"abc"</>
 Received: <r>{"0": "a", "1": "b", "2": "c"}</>
 `;
 
+exports[`.toEqual() {pass: false} expect({"a": "foo"}).toEqual({"a": "bar"}) 1`] = `
+<d>expect(</><r>received</><d>).</>toEqual<d>(</><g>expected</><d>) // deep equality</>
+
+<g>- Expected  - 1</>
+<r>+ Received  + 1</>
+
+<d>  Object {</>
+<g>-   "a": "bar",</>
+<r>+   "a": "foo",</>
+<d>  }</>
+`;
+
 exports[`.toEqual() {pass: false} expect({"a": 1, "b": 2}).toEqual(ObjectContaining {"a": 2}) 1`] = `
 <d>expect(</><r>received</><d>).</>toEqual<d>(</><g>expected</><d>) // deep equality</>
 

packages/expect/src/__tests__/matchers.test.js

@@ -435,6 +435,17 @@ describe('.toEqual()', () => {
     [{a: 1}, {a: 2}],
     [{a: 5}, {b: 6}],
     [Object.freeze({foo: {bar: 1}}), {foo: {}}],
+    [
+      {
+        get a() {
+          return 'foo';
+        },
+        set a(value) {
+          throw new Error('noo');
+        },
+      },
+      {a: 'bar'},
+    ],
     ['banana', 'apple'],
     ['1\u{00A0}234,57\u{00A0}$', '1 234,57 $'], // issues/6881
     [

packages/jest-matcher-utils/src/Replaceable.ts

@@ -37,7 +37,7 @@ export default class Replaceable {
       });
       Object.getOwnPropertySymbols(this.object).forEach(key => {
         const descriptor = Object.getOwnPropertyDescriptor(this.object, key);
-        if ((descriptor as PropertyDescriptor).enumerable) {
+        if (descriptor?.enumerable) {
           cb(this.object[key], key, this.object);
         }
       });
@@ -57,7 +57,12 @@ export default class Replaceable {
     if (this.type === 'map') {
       this.object.set(key, value);
     } else {
-      this.object[key] = value;
+      const descriptor = Object.getOwnPropertyDescriptor(this.object, key);
+
+      // do not try to assign to anything that has a setter
+      if (descriptor?.set === undefined) {
+        this.object[key] = value;
+      }
     }
   }
 }