Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default name and rootDir when not provided in config object #976

Closed
wants to merge 2 commits into from
Closed

default name and rootDir when not provided in config object #976

wants to merge 2 commits into from

Conversation

seanparmelee
Copy link
Contributor

This PR addresses #955. I ran into the same problem when using grunt-jest passing a config object in the options. Similar to how it behaves when using package.json as the configuration source, I'm defaulting the name and rootDir when they are not provided.

@ghost ghost added the CLA Signed ✔️ label May 6, 2016
});

describe('config object', () => {
beforeEach(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the empty block :)

@cpojer
Copy link
Member

cpojer commented May 9, 2016

Thanks for adding a test! I added a few minor comments – would you mind rebasing and fixing them? :)

@seanparmelee
Copy link
Contributor Author

Thanks for the feedback @cpojer! I've addressed all your comments, please let me know if you'd like me to squash my commits.

@cpojer
Copy link
Member

cpojer commented May 12, 2016

@facebook-github-bot import

@ghost
Copy link

ghost commented May 12, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@cpojer
Copy link
Member

cpojer commented May 12, 2016

@facebook-github-bot shipit

@cpojer
Copy link
Member

cpojer commented May 12, 2016

I modified your change a little bit to set the name in normalize, no matter where the config is coming from – I think that's gonna be safer for the future :) Thank you for your contribution and I'm looking forward to more :)

@ghost
Copy link

ghost commented May 12, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants