-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default name and rootDir when not provided in config object #976
Conversation
}); | ||
|
||
describe('config object', () => { | ||
beforeEach(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the empty block :)
Thanks for adding a test! I added a few minor comments – would you mind rebasing and fixing them? :) |
Thanks for the feedback @cpojer! I've addressed all your comments, please let me know if you'd like me to squash my commits. |
@facebook-github-bot import |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
@facebook-github-bot shipit |
I modified your change a little bit to set the name in |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR addresses #955. I ran into the same problem when using grunt-jest passing a
config
object in the options. Similar to how it behaves when usingpackage.json
as the configuration source, I'm defaulting thename
androotDir
when they are not provided.