Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-runner] Don't print warning to stdout when using --json #9843

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Apr 19, 2020

Summary

This warning should go to stderr, otherwise when you have a test that leaks while using --json it will produce invalid JSON when reading the stdout of a Jest process.

Test plan

This regressed in Jest through #8206 and made Jest on CI at FB fail. Verified this change fixes it.

@codecov-io
Copy link

Codecov Report

Merging #9843 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9843      +/-   ##
==========================================
- Coverage   64.52%   64.51%   -0.02%     
==========================================
  Files         290      290              
  Lines       12325    12325              
  Branches     3048     3048              
==========================================
- Hits         7953     7951       -2     
- Misses       3732     3733       +1     
- Partials      640      641       +1     
Impacted Files Coverage Δ
packages/jest-runner/src/index.ts 64.00% <0.00%> (ø)
packages/expect/src/utils.ts 94.96% <0.00%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3681cca...70b2fcc. Read the comment docs.

@SimenB SimenB merged commit ed4cadb into jestjs:master Apr 19, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
@cpojer cpojer deleted the json-stderr branch October 18, 2022 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants