Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: ignore hidden files by default #9887

Conversation

leonardovillela
Copy link
Contributor

Summary

Fix #9829

I was thinking about adding an e2e test to package.json bug described in the issue above, but I was in doubt because probably the modulePathIgnorePatterns config behavior was tested in one of the existing e2e tests, so I only did unit tests. But if you think it's good to have e2e tests I can add it.

Test plan

Unit tests added.

@leonardovillela leonardovillela changed the title fix: ignore hidden files by default [WIP] fix: ignore hidden files by default Apr 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #9887 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9887   +/-   ##
=======================================
  Coverage   64.49%   64.50%           
=======================================
  Files         291      291           
  Lines       12389    12395    +6     
  Branches     3059     3064    +5     
=======================================
+ Hits         7990     7995    +5     
  Misses       3753     3753           
- Partials      646      647    +1     
Impacted Files Coverage Δ
packages/jest-config/src/Defaults.ts 100.00% <ø> (ø)
packages/jest-config/src/normalize.ts 77.04% <100.00%> (+0.38%) ⬆️
packages/jest-runtime/src/index.ts 59.33% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f107a3...75f5898. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest fails when git branch name looks like a json file
3 participants