chore: use Maps rather than objects as cache holders
#9902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Apr 27, 2020
| type StringMap = Map<string, string>; | ||
| type BooleanMap = Map<string, boolean>; | ||
|
|
||
| const fromEntries: typeof Object.fromEntries = |
There was a problem hiding this comment.
Object.fromEntries was added in node 12.
Can ditch this when jest-resolve uses a Map as well
thymikee
reviewed
Apr 28, 2020
thymikee
reviewed
Apr 28, 2020
SimenB
force-pushed
the
maps-over-objects
branch
from
bdae3ac to
1962370
Compare
SimenB
commented
Apr 28, 2020
packages/jest-runtime/src/index.ts
Outdated
| this._moduleImplementation = undefined; | ||
|
|
||
| // @ts-ignore | ||
| this._config = undefined; |
There was a problem hiding this comment.
probably not needed, but doesn't hurt do help GC along
SimenB
force-pushed
the
maps-over-objects
branch
from
ecc9aae to
94cbbd7
Compare
|
Ah, this of course breaks pretty hard when the user does something after teardown |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Maps are about twice as fast for larger data sets in Chrome 80, very much likely this applies to Node as well: https://stackoverflow.com/a/55711780/1850276Similar to #8232, but applied to all caches.
(Includes #9900 as I forgot to switch to master first and can't be bothered to fix the conflict twice 😀 Please review second commit until I rebase)Test plan
Green CI.