fix: disallow hook definitions in tests #9957
Conversation
SimenB
force-pushed
the
disallow-hooks-in-tests
branch
from
5b8382b to
2983c35
Compare
Codecov Report
@@ Coverage Diff @@
## master #9957 +/- ##
=======================================
Coverage 64.06% 64.07%
=======================================
Files 293 293
Lines 12457 12459 +2
Branches 3069 3070 +1
=======================================
+ Hits 7981 7983 +2
- Misses 3833 3834 +1
+ Partials 643 642 -1
Continue to review full report at Codecov.
|
SimenB
force-pushed
the
disallow-hooks-in-tests
branch
from
7243953 to
b212f99
Compare
| ); | ||
| break; |
There was a problem hiding this comment.
pushing into the errors array is essentially what happened before, except we don't go through the handler again into the error case
| break; | ||
| } else if (hasStarted) { | ||
| state.unhandledErrors.push( | ||
| new Error( |
There was a problem hiding this comment.
no need to mutate the message in asyncError, this is sync code
| @@ -214,7 +214,7 @@ export type TestError = Exception | [Exception | undefined, Exception]; // the e | |||
| export type TestEntry = { | |||
| type: 'test'; | |||
| asyncError: Exception; // Used if the test failure contains no usable stack trace | |||
| errors: TestError; | |||
| errors: Array<TestError>; | |||
There was a problem hiding this comment.
it was any before... Array<any> is more accurate, but still not particularly good 😅
There was a problem hiding this comment.
This is weird, now it can be an array of tuples? Look at TestError
There was a problem hiding this comment.
that fits reality
https://github.com/facebook/jest/blob/3375ac3b515e62ca1450e9a154ffdbdf7dc7e1f7/packages/jest-circus/src/eventHandler.ts#L147
https://github.com/facebook/jest/blob/3375ac3b515e62ca1450e9a154ffdbdf7dc7e1f7/packages/jest-circus/src/eventHandler.ts#L150
https://github.com/facebook/jest/blob/3375ac3b515e62ca1450e9a154ffdbdf7dc7e1f7/packages/jest-circus/src/eventHandler.ts#L179
There was a problem hiding this comment.
you can see it used in formatNodeAssertErrors.ts
| @@ -16,6 +16,7 @@ FAIL __tests__/asyncDefinition.test.js | |||
| 14 | }); | |||
| 15 | }); | |||
|
|
|||
| at eventHandler (../../packages/jest-circus/build/eventHandler.js:143:11) | |||
There was a problem hiding this comment.
should be stripped out from stack trace
There was a problem hiding this comment.
I tried, it was painful 😀 We could copy the stack from asyncError I guess
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Not breaking after #8096, just a cleaner error in this case.
Test plan
Test added