Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiline content #45

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Conversation

jesusoterogomez
Copy link
Owner

This PR adds support for multiline content using feedback from issues #26 and #44

I need help to test that this covers current use cases. I have tested some notifications across one of my applications and the change seems to be fully backwards compatible, but I want to make sure that I'm not breaking anyone's app with this update.

If you would like to contribute, please follow these steps to try the latest version in your application:

git clone git@github.com:jesusoterogomez/react-notify-toast.git
cd react-notify-toast
npm link && npm run compile

# in your application
npm link react-notify-toast

# Run your app as normal and test that notifications work as expected

To test a multiline notification

// JSX content
notify.show(<span>This is a <br/>multiline</br>notification</span>);

// String
notify.show("use an insanely long string here");

@jesusoterogomez
Copy link
Owner Author

screen shot 2017-10-20 at 3 01 21 pm

I am using multiline notifications for this purpose with the latest changes.

@jesusoterogomez jesusoterogomez merged commit b35b59b into master Oct 20, 2017
@stephenfeather
Copy link

Put into the dev cycle on friday late, the stakeholders will be testing on Monday. Thanks.

@jesusoterogomez jesusoterogomez deleted the fix/26/multiline_content/1 branch November 26, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants