Change broker to bootstrapServers #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
broker : Uriarg in the Producer and Consumer config wrappers currently constrain thebootstrapServerspassed to a single entry.This obscures a core function of an idiomatic Kafka Client for a debatable reason
There is currently a workaround (which I didnt realize in advance of implementing this 😊) - supply a dummy value for
brokerand then stuff in a custombootstrapServersvalue viacustomI may consider deferring the merging of this until 2.0.0 depending on what folks think
If anyone has any insights like e.g. telling me that in practice
bootstrapServersare never usefully >1 therefore this makes no sense, let me know too!This will also flow through to the parallel implementation contained in https://github.com/jet/propulsion/tree/master/src/Propulsion.Kafka0