Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Change KafkaConsumer/ProducerConfig autoOffsetReset, requestTimeout #52

Merged
merged 5 commits into from
May 13, 2020

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented May 13, 2020

  • The longstanding default for autoOffsetReset for FsKafka has always been earliest, which is a safe default, but is not the Confluent.Kafka one (which is Latest).
    This PR removes that defaulting in order to force a deliberate choice on the part of the user.
  • Exposes requestTimeout on KafkaProducerConfig.Create

cc @wantastic84 @swrhim

@bartelink bartelink changed the title Remove KafkaConsumerConfig autoOffsetReset defaulting Add/Change KafkaConsumer/ProducerConfig autoOffsetReset, requestTimeout May 13, 2020
@bartelink bartelink merged commit 9e18e5a into master May 13, 2020
@bartelink bartelink deleted the api-cleanup branch May 13, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant