Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak logging #57

Merged
merged 9 commits into from
Jun 10, 2020
Merged

Tweak logging #57

merged 9 commits into from
Jun 10, 2020

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Jun 9, 2020 •
edited
Loading

  • Remove incorrect Producer logging (it logs before the wait hence generally reports 0), as spotted by @wantastic84
  • Add .Verbose log for handler invocations 🙏 @wantastic84
  • FsKafka0: Add ConsumerError logging 🙏 @svairagade
  • FsKafka: Distinguish Fatal Errors from by non-fatal by reducing level to Warning 🙏@svairagade

@bartelink bartelink changed the title Remove stray logging Tweak logging Jun 9, 2020
svairagade and others added 6 commits June 10, 2020 18:03
@bartelink bartelink merged commit 096cf3b into master Jun 10, 2020
@bartelink bartelink deleted the logging branch June 10, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartelink @wantastic84 @svairagade